adding callback on shutdown #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @throws IllegalStateException if this method is called more than once per instance | ||
| */ | ||
| void onShutdown(Completable c); |
There was a problem hiding this comment.
Instead of returning void, I would return the previous Completable (and allow changing the callback).
There was a problem hiding this comment.
Actually, why to ask for a Completable? This is like a close future for the socket, which is a single instance that anyone can subscriber/listen to. So, why not have something like:
Completable shutdownListener();
|
@stevegury @NiteshKant changed it so that it returns a Publisher that is completed when the ReactiveSocket is closed |
|
@robertroeser doesn't it make sense to have a |
|
@NiteshKant ok switched it back to a Completable |
|
ok revelation for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a callback that is called when a reactive socket is closed.