Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject empty fragments #903

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Reject empty fragments #903

merged 1 commit into from
Aug 3, 2020

Conversation

rstoyanchev
Copy link
Contributor

Proposed fix for #895.

@rstoyanchev rstoyanchev added this to the 1.0.2 milestone Aug 3, 2020
@rstoyanchev rstoyanchev requested a review from OlegDokuka August 3, 2020 10:42
@rstoyanchev rstoyanchev self-assigned this Aug 3, 2020
@rstoyanchev
Reject empty fragments
8ea36ca 
Closes rsocketgh-895

Signed-off-by: Rossen Stoyanchev <[email protected]>
@rstoyanchev
Copy link
Contributor Author

Last commit was just a rebase on top of the latest 1.0.x.

OlegDokuka
OlegDokuka approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@OlegDokuka OlegDokuka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we have not added any logic for checking the size of the upcoming frames. But that can be added in 1.1

@rstoyanchev rstoyanchev merged commit 8ea36ca into rsocket:1.0.x Aug 3, 2020
@OlegDokuka OlegDokuka linked an issue Aug 3, 2020 that may be closed by this pull request
RSocket server is subject to empty frames flood denial-of-service #895
Closed
@rstoyanchev rstoyanchev deleted the 895-empty-frame branch August 10, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels
enhancement
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

RSocket server is subject to empty frames flood denial-of-service
2 participants
@rstoyanchev @OlegDokuka