Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL of RSocket Demo Client in Readme #939

Closed
wants to merge 3 commits into from
Closed

Update URL of RSocket Demo Client in Readme #939

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
837a610
Update URL of RSocket Demo Client
jexp Oct 3, 2020
3a53aef
Updated version to 1.1.0-M2 and added spring-milestone repo for the r…
jexp Oct 3, 2020
3449f97
tabs vs spaces
jexp Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ Example:
```groovy
repositories {
mavenCentral()
maven { url 'https://repo.spring.io/milestone' }
}

dependencies {
implementation 'io.rsocket:rsocket-core:1.1.0-M1'
implementation 'io.rsocket:rsocket-transport-netty:1.1.0-M1'
implementation 'io.rsocket:rsocket-core:1.1.0-M2'
implementation 'io.rsocket:rsocket-transport-netty:1.1.0-M2'
}
```

Expand All @@ -40,6 +42,7 @@ Example:
```groovy
repositories {
maven { url 'https://oss.jfrog.org/oss-snapshot-local' }
maven { url 'https://repo.spring.io/milestone' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maven { url 'https://repo.spring.io/milestone' }
maven { url 'https://repo.spring.io/snapshot' }

We usually depend on the snapshots or reactor, thus if such occasion happens, it is better to specify a snapshot repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this does not fix #940 since this section is related to the snapshots, but M1 now specified as a release one, so I would suggest adding a similar section for release and keep it until we have a GA for 1.1.0

}
dependencies {
implementation 'io.rsocket:rsocket-core:1.1.0-SNAPSHOT'
Expand Down Expand Up @@ -83,7 +86,7 @@ import java.net.URI;

public class ExampleClient {
public static void main(String[] args) {
WebsocketClientTransport ws = WebsocketClientTransport.create(URI.create("ws://rsocket-demo.herokuapp.com/ws"));
WebsocketClientTransport ws = WebsocketClientTransport.create(URI.create("wss://rsocket-demo.herokuapp.com/rsocket"));
RSocket clientRSocket = RSocketConnector.connectWith(ws).block();

try {
Expand Down