This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Add support for optimized requires. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rspec/rspec-expectations#476 for the discussion and background to this.
| # `require_relative` is preferred when available because it is always O(1), | ||
| # regardless of the number of dirs in $LOAD_PATH. `require`, on the other | ||
| # hand, does a linear O(N) search over the dirs in the $LOAD_PATH until | ||
| # it can resolve the file relative to one of the dirs. |
|
Any other concerns or is this good to merge, @xaviershay? |
| module RSpec | ||
| module Support | ||
| # @api private | ||
| # | ||
| # Defines a helper method that is optimized to require files from the | ||
| # named lib. The passed block MUST be `{ |f| require_relative f }` |
There was a problem hiding this comment.
Clear explanation, but that is a weird declaration requirement 😀
Now I know another good use case for the binding_of_caller gem… (but since we control all the code here, there's really no need).
There was a problem hiding this comment.
I wondered about passing in __FILE__ and building a require to the absolute path, which should also shortcut the lookup?
There was a problem hiding this comment.
I wondered about passing in FILE and building a require to the absolute path, which should also shortcut the lookup?
I think that would probably work, but I dislike it for a few versions:
- Years of doing ruby has taught me that absolute requires are rarely what you want.
- Mixing absolute and relative requires can often lead to pain, where it allows a file to be loaded twice if you reference it in two different ways
require_relativeis the 1.9+ way of doing this; why re-invent it?
|
Any other concerns, @JonRowe? |
|
Nope, LGTM |
myronmarston
added a commit
that referenced
this pull request
Feb 24, 2014
Add support for optimized requires.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rspec/rspec-expectations#476
for the discussion and background to this.