-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to select config format in new project menu #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Thank you 👍
I get one approval, I'll merge ! 😄 @yihui you can tweak later if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! I'll probably tweak the order of all these options later. Thanks!
I tried several layout of them and decided it was interesting to have this option just above the one regarding YAML metadata so that you don't confuse the two. However the SelectInput creates a space below that makes it a bit weird. happy tweaking ! |
…input from #607 to checkbox so the UI is slightly tidier
It is better without the select input. Nice idea to have also allow TRUE / FALSE in |
If I saw this, I'm not sure I'd know what to do. Could we make it more clear what the alternative is? (i.e., if all I know is YAML, sure this sounds great!) Maybe the reword could be "convert config file to YAML (if config.toml file is found, comments are removed)"? |
Good suggestion! Will do in a second.
That might be too much in the UI. If there were a way to show a help icon, I'd be totally happy to add these words to the help text. In addition, when #560 is solved, we won't need to emphasize that comments will be lost in the conversion. |
That makes sense- thanks! |
This add a selector menu for choosing config format
closes #606