Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select config format in new project menu #607

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Apr 7, 2021

This add a selector menu for choosing config format
image

closes #606

@cderv cderv requested review from apreshill and yihui April 7, 2021 10:50
Copy link
Contributor

@apreshill apreshill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you 👍

@cderv
Copy link
Collaborator Author

cderv commented Apr 7, 2021

I get one approval, I'll merge ! 😄

@yihui you can tweak later if needed.

@cderv cderv changed the title Allow to select config format in New project menu Allow to select config format in new project menu Apr 7, 2021
@cderv cderv merged commit 28f9606 into master Apr 7, 2021
@cderv cderv deleted the config-toml-project-template branch April 7, 2021 12:16
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! I'll probably tweak the order of all these options later. Thanks!

@cderv
Copy link
Collaborator Author

cderv commented Apr 7, 2021

I tried several layout of them and decided it was interesting to have this option just above the one regarding YAML metadata so that you don't confuse the two.

However the SelectInput creates a space below that makes it a bit weird.

happy tweaking !

yihui added a commit that referenced this pull request Apr 7, 2021
…input from #607 to checkbox so the UI is slightly tidier
@yihui
Copy link
Member

yihui commented Apr 7, 2021

How does this version look to you?

image

@cderv
Copy link
Collaborator Author

cderv commented Apr 7, 2021

It is better without the select input. Nice idea to have also allow TRUE / FALSE in new_site() !

@apreshill
Copy link
Contributor

apreshill commented Apr 7, 2021

If I saw this, I'm not sure I'd know what to do. Could we make it more clear what the alternative is? (i.e., if all I know is YAML, sure this sounds great!) Maybe the reword could be "convert config file to YAML (if config.toml file is found, comments are removed)"?

@yihui
Copy link
Member

yihui commented Apr 7, 2021

convert config file to YAML

Good suggestion! Will do in a second.

image

(if config.toml file is found, comments are removed)

That might be too much in the UI. If there were a way to show a help icon, I'd be totally happy to add these words to the help text. In addition, when #560 is solved, we won't need to emphasize that comments will be lost in the conversion.

yihui added a commit that referenced this pull request Apr 7, 2021
@apreshill
Copy link
Contributor

That makes sense- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No config.toml
3 participants