Refactoring of heading component #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich-iannone
changed the title
|
I'm going to need you to walk me through this one |
* master: Use `sass` package from CRAN (not GitHub) (#313)
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
schloerke
reviewed
Jul 9, 2019
| @@ -318,3 +318,46 @@ is_adjacent_separate <- function(group_1, | |||
|
|
|||
| return(TRUE) | |||
| } | |||
|
|
|||
| str_catalog <- function(item_vector, | |||
There was a problem hiding this comment.
where is this function used?
There was a problem hiding this comment.
It's used in the validate_style_in() function (and I'm thinking of using it elsewhere).
schloerke
requested changes
Jul 9, 2019
schloerke
reviewed
Jul 11, 2019
| @@ -243,30 +243,28 @@ add_summary_location_row <- function(loc, | |||
| if (df_type == "footnotes_df") { | |||
|
|
|||
| attr(data, df_type) <- | |||
There was a problem hiding this comment.
Later, add_location_row_* methods might want to return data. (Move the attr(data, df_type) inside the function)
There was a problem hiding this comment.
This would be a nice change. Assigning to attr(data, ...) sometimes is inconsistent.
There was a problem hiding this comment.
Just made this an issue: #315
schloerke
approved these changes
Jul 11, 2019
This was referenced Jul 11, 2019
Closed
rich-iannone
added a commit
that referenced
this pull request
Jul 12, 2019
* master: Add the `cells_stubhead_label()` location helper (#276) Refactoring of the `tab_options()` function (#288) Add the `path` argument to `gtsave()` (#290) Refactoring of heading component (#239) Use `sass` package from CRAN (not GitHub) (#313) Add options related to the table <div> (#285) Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone
added a commit
that referenced
this pull request
Jul 15, 2019
* master: Add the `cells_stubhead_label()` location helper (#276) Refactoring of the `tab_options()` function (#288) Add the `path` argument to `gtsave()` (#290) Refactoring of heading component (#239) Use `sass` package from CRAN (not GitHub) (#313) Add options related to the table <div> (#285) Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone
added a commit
that referenced
this pull request
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the earlier refactoring effort, which made available several new utility functions for composing strings. Additional utility functions are included here to help with gathering footnote glyphs and custom styles for cells.
Templating with
glueis used here to compose the HTML and LaTeX fragments (along withpaste_between()). Some improvements to the CSS classes for the title and subtitle were also made.