Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to libuv 1.15.0 #91

Merged
merged 3 commits into from
Oct 12, 2017
Merged

Upgrade to libuv 1.15.0 #91

merged 3 commits into from
Oct 12, 2017

Conversation

wch
Copy link
Collaborator

@wch wch commented Oct 11, 2017

This closes #42. I've tested it with shiny::runExample("01_hello") with Shiny 1.0.5 on macOS 10.12.6, Windows 10, and Centos 6.

Unlike the libuv-1.8.0 branch, on Windows, this builds libuv using Rtools, by simply running make -f Makefile.mingw. (Thanks to @jimhester!)

  • The first commit just updates the files for libuv
  • The second commit makes modifications to httpuv code so that it all works. For the second commit, many changes were borrowed from 5a4ba77.

@wch wch merged commit 2bf07cc into master Oct 12, 2017
@wch wch deleted the libuv-1.15.0 branch October 12, 2017 17:41
@wch wch mentioned this pull request Oct 12, 2017
@QuLogic
Copy link
Contributor

QuLogic commented Oct 31, 2017

Is the source for libuv now pristine? (I'm wondering if httpuv could be built against a system copy now).

@wch
Copy link
Collaborator Author

wch commented Oct 31, 2017

The copy of libuv that's included is unchanged from original sources.

@QuLogic
Copy link
Contributor

QuLogic commented Nov 1, 2017

Great!

@QuLogic QuLogic mentioned this pull request Nov 9, 2017
@QuLogic
Copy link
Contributor

QuLogic commented Nov 10, 2017

Has any thought been made to building against a system copy? Would a patch be accepted?

One of the troubles with bundling is that you need to be on top of any issues in the code you're bundling. For example, the ancient copy of libuv that is in the current release (but not git) contains a CVE, 2015-0278, though I would hope that no-one runs R with elevated privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update libuv to v1.x
2 participants