Skip to content

Commit

Permalink
get rid of xfun::attr(): yihui/xfun#96
Browse files Browse the repository at this point in the history
  • Loading branch information
yihui committed Jan 7, 2025
1 parent 551bae6 commit 59c32c1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: pagedown
Type: Package
Title: Paginate the HTML Output of R Markdown with CSS for Print
Version: 0.21.1
Version: 0.21.2
Authors@R: c(
person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666")),
person("Romain", "Lesur", role = c("aut", "cph"), comment = c(ORCID = "0000-0002-0721-5595")),
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# CHANGES IN pagedown VERSION 0.22

- No longer use `xfun::attr()` (which will be removed from **xfun**).

# CHANGES IN pagedown VERSION 0.21

- `html_paged()` and other formats using `paged.js` now informs **knitr** that its JS and CSS dependencies will be loaded by setting the `is.paged.js` global knit option. Use `isTRUE(knitr::opts_knit$get("is.paged.js"))` to detect it (thanks, @sylvaine31, @davidgohel, #332).
Expand Down
2 changes: 1 addition & 1 deletion R/chrome.R
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ chrome_print = function(
on.exit(kill_chrome(), add = TRUE)

remote_protocol_ok = is_remote_protocol_ok(debug_port, verbose = verbose)
stream_pdf_available = isTRUE(xfun::attr(remote_protocol_ok, 'stream_pdf_available'))
stream_pdf_available = isTRUE(attr(remote_protocol_ok, 'stream_pdf_available'))

if (!remote_protocol_ok)
stop('A more recent version of Chrome is required. ')
Expand Down
1 change: 1 addition & 0 deletions pagedown.Rproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: 89f133bc-10c3-4fbf-926c-a1ce35320145

RestoreWorkspace: Default
SaveWorkspace: Default
Expand Down

0 comments on commit 59c32c1

Please sign in to comment.