Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in version parsing function msg. #286

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Fix off-by-one error in version parsing function msg. #286

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e582270
Fix off-by-one error in version parsing function msg.
nathanjmcdougall Jul 25, 2024
f2fd9a9
Merge branch 'main' into feature/283-fix-off-by-one-bug-in-msg
isabelizimm Aug 6, 2024
8b88b59
Update pins/tests/test_versions.py
isabelizimm Aug 6, 2024
f68d2d5
Merge branch 'main' into dev-283
isabelizimm Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pins/tests/test_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,20 @@ def test_version_from_string():
assert version.hash == "baf3f"


def test_version_from_string_too_many_hyphens():
with pytest.raises(
PinsVersionError, match="version string can only have 1 '-', but contains 2"
):
Version.from_string("20220209T220116Z-baf3f-")


def test_version_from_string_too_few_hyphens():
with pytest.raises(
PinsVersionError, match="version string can only have 1 '-', but contains 0"
):
Version.from_string("20220209T220116Zbaf3f")
isabelizimm marked this conversation as resolved.
Show resolved Hide resolved


def test_version_from_string_baddate():
with pytest.raises(PinsVersionError, match="Invalid date part of version: bug"):
Version.from_string("bug-baf3f")
Expand Down
Loading