Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

RuntimeWarning: coroutine 'AsyncFileContentsManager.get' was never awaited #344

Closed
bcwu opened this issue Feb 23, 2023 · 0 comments · Fixed by #347
Closed

RuntimeWarning: coroutine 'AsyncFileContentsManager.get' was never awaited #344

bcwu opened this issue Feb 23, 2023 · 0 comments · Fixed by #347
Assignees
Labels

Comments

@bcwu
Copy link
Contributor

bcwu commented Feb 23, 2023

Upstream breaking change made async the default handler for contents_manager in APIHandler. Existing code paths that use contents_manager need to be updated to handle async:

model = self.contents_manager.get(path=nb_path)

if not hasattr(self.contents_manager, "_get_os_path"):

os_path = self.contents_manager._get_os_path(nb_path)

@mmarchetti mmarchetti self-assigned this Feb 24, 2023
@tdstein tdstein linked a pull request Feb 27, 2023 that will close this issue
@tdstein tdstein added the bug label Feb 27, 2023
@tdstein tdstein self-assigned this Feb 28, 2023
@bcwu bcwu closed this as completed in #347 Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants