This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
344 async coroutine bug #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
approved these changes
Feb 27, 2023
Moves ContextManager model fetching to a seperate module (`rsconnect_jupyter.managers`) to faciliate isolated unit testing.
tdstein
force-pushed
the
344-async-coroutine-bug
branch
from
329710a to
51a6ca0
Compare
bcwu
approved these changes
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds await calls for Jupyter versions where AsyncContextManager is used.
Connected to #344
Testing Notes / Validation Steps
The unit tests validate that async expectations are met.
For user testing, published a Notebook to Connect using the latest version of Jupyter Notebooks.