Refactor installation #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'testthat' imports 'waldo' imports 'rematch2' imports 'tibble', except that on github actions runner macOS-latest with r-release (4.1) tibble is not installed as part of `install_local(dependencies=TRUE)`. This only presents on macOS with R 4.1. Likely a transient bug not worth tracking down. This refactor replaces `expect_that` with `expect`, to avoid the need for tibble.
dfalbel
approved these changes
Jul 27, 2021
|
Hello, The code that installs tensorflow and keras has been refactored. install.packages("remotes")
remotes::install_github(paste0("rstudio/", c("reticulate", "tensorflow", "keras")))
reticulate::install_miniconda() # skip this if you want to self-install conda or use venv
keras::install_keras()Please let us know if after updating you are still encountering installation issues: closes #445 |
This was referenced Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
install_tensorflow()and related CI tests.Installation:
keras::install_keras()andtensorflow::install_tensorflow().install_keras()is now a mostly thin wrapper aroundinstall_tensorflow()that also pulls some additional python packages.install_tensorflow()will pull the latest available patch release (e.g., "2.4" now pulls "2.4.2", previously it would pull "2.4.0"CI: