Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise postrotate script in logrotate config with stock el packages #123

Closed
qha opened this issue Dec 22, 2022 · 3 comments · Fixed by #124
Closed

Harmonise postrotate script in logrotate config with stock el packages #123

qha opened this issue Dec 22, 2022 · 3 comments · Fixed by #124
Assignees

Comments

@qha
Copy link

qha commented Dec 22, 2022

On el8 and el9 the postrotate script in logrotate config seem to be pretty much equivalent to that shipped with the stock (rh)el packages. They are not identical however which will keep sharedscripts from merging them with other postrotate scripts that try to harmonise with the stock packages.

(We try to do this for a /var/log/debug that we added to our rsyslog config.)

The differences are:
systemctl kill -s HUP rsyslog.service in the Adiscon packages vs:
/usr/bin/systemctl kill -s HUP rsyslog.service >/dev/null 2>&1 || true in the stock packages.

@qha
Copy link
Author

qha commented Dec 22, 2022

(On el7 i presume #42 makes this a nonstarter.)

@rgerhards rgerhards assigned rgerhards and alorbach and unassigned rgerhards Dec 22, 2022
@rgerhards
Copy link
Member

@alorbach sounds good to me, what do you think?

@alorbach
Copy link
Member

We can adapt the changes from the stock packages, they look reasonable to me.

alorbach added a commit to alorbach/rsyslog-pkg-rhel-centos that referenced this issue Jan 3, 2023
Matching the EL8 / EL9 stock version of the logrotate script now.

closes: rsyslog#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants