Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.3.0] Bump Plugin Version and Update Readme Files #373

Merged
merged 11 commits into from
Dec 23, 2024

Conversation

Vedant-Gandhi
Copy link
Contributor

Description

Changes

  • Updated the Plugin Version to 2.3.0
  • Updated the po and mo files.
  • Updated Readme files reflecting the changelog and plugin version.

@Vedant-Gandhi Vedant-Gandhi marked this pull request as ready for review December 19, 2024 06:19
readme.txt Show resolved Hide resolved
README.md Show resolved Hide resolved
readme.txt Outdated
@@ -6,7 +6,7 @@ License: GPLv2 or later (of-course)
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Requires at least: 3.0
Tested up to: 6.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed updating Tested up to. Please makesure that fields in readme.md and readme.txt are similar.

Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise a develop PR first before merging to master.
We will first test the changes on develop.

Next, if we have already merged the fixes/features on master, we can directly raise a version bump PR for master.

If the changes are not merged, then a master <-> develop sync PR should be raised to migrate the develop commits to master after testing develop. (ref PR: #318)

@@ -113,6 +113,18 @@ define( 'RT_WP_NGINX_HELPER_REDIS_PORT', '6000' );
define( 'RT_WP_NGINX_HELPER_REDIS_PREFIX', 'page-cache:' );
```

**Q. Can I override the redis socket path, username, password?**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vedant-Gandhi, Why does the current master PR have more changes than our develop PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pathan-Amaankhan I have added the FAQ in Readme for new redis constants introduced in the new plugin version.

Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we added this on develop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref - #375

@Vedant-Gandhi Vedant-Gandhi merged commit 6946181 into master Dec 23, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants