-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.3.0] Bump Plugin Version and Update Readme Files #373
Conversation
readme.txt
Outdated
@@ -6,7 +6,7 @@ License: GPLv2 or later (of-course) | |||
License URI: http://www.gnu.org/licenses/gpl-2.0.html | |||
Requires at least: 3.0 | |||
Tested up to: 6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed updating Tested up to. Please makesure that fields in readme.md and readme.txt are similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please raise a develop PR first before merging to master.
We will first test the changes on develop.
Next, if we have already merged the fixes/features on master, we can directly raise a version bump PR for master.
If the changes are not merged, then a master <-> develop sync PR should be raised to migrate the develop commits to master after testing develop. (ref PR: #318)
@@ -113,6 +113,18 @@ define( 'RT_WP_NGINX_HELPER_REDIS_PORT', '6000' ); | |||
define( 'RT_WP_NGINX_HELPER_REDIS_PREFIX', 'page-cache:' ); | |||
``` | |||
|
|||
**Q. Can I override the redis socket path, username, password?** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vedant-Gandhi, Why does the current master PR have more changes than our develop PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pathan-Amaankhan I have added the FAQ in Readme for new redis constants introduced in the new plugin version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we added this on develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref - #375
Description
Changes