fix: Set attribute value to class #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using attribute does set the css class correctly however the attribute name needs to be class instead of className. Using className will set classes as `classname` in dom nodes and `className` in svg nodes which is incorrect.
|
Many apologies for this oversight. |
|
So just to confirm, |
|
Published as 17.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #563
Context
Using attribute does set the css class correctly however the attribute
name needs to be class instead of className.
Using className will set classes as
classnamein dom nodes andclassNamein svg nodes which is incorrect.Here we can see the incorrect attribute name. On the left we should be seeing a handsome
elm-select. No styles are applied.And with correct class.
