Branding fixes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he issue but this change was easier
|
This looks like the right fix. Yes, I should probably do something neater for checking whether it is a relative import or not. |
rtibbles
pushed a commit
that referenced
this pull request
Jul 26, 2019
Docs update about sentry_sdk
rtibbles
pushed a commit
that referenced
this pull request
Oct 23, 2019
updates regarding app bar color tokens
rtibbles
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address some issues I was having, demo'd here: #6
In particular, modules are now compiled with absolute paths so that local relative references are resolved.
Also found an issue where
requirestatements with dots in the names were skipped (e.g. if a file is named with .styl or .vue). The logic responsible is here: https://github.com/rtibbles/kolibri/blob/brand_my_build/frontend_build/src/apiSpecExportTools.js#L78I briefly looked at fixing the code but instead just took out the dots. I'll make an issue for this.