This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
fix(credential-processs): Remove initial tty available check #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description:** Rather than check for the ability to create a tty connection and failing if we can't, continue as if we have one. In the case where we have a valid session, we don't need the tty, so the credential-process command will continue to work. If we need to use the tty (because no valid session), we already are raising an error, so let it fail then. **Testing:** `bazel test //...` and manually testing locally
rtkjbeverly
approved these changes
Aug 23, 2021
| } | ||
|
|
||
| return console.NewConsoleReader(true) | ||
| return console.NewConsoleReader(limited) |
There was a problem hiding this comment.
This should just impact the non-Mac cases, as the darwin logic handles the applescript selection.
rtkaheller
added a commit
that referenced
this pull request
Aug 25, 2021
**Description:** Missed running go fmt against the changes in #44. Fix it so CI will pass. **Testing:** None
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Rather than check for the ability to create a tty
connection and failing if we can't, continue as if we have one. In the
case where we have a valid session, we don't need the tty, so the
credential-process command will continue to work. If we need to use the
tty (because no valid session), we already are raising an error, so let
it fail then.
Testing:
bazel test //...and manually testing locally