fix: clippy warnings

crates/core/src/kernel/snapshot/mod.rs

@@ -393,7 +393,7 @@ impl EagerSnapshot {
     ) -> DeltaResult<Self> {
         let mut visitors = tracked_actions
             .iter()
-            .flat_map(|a| get_visitor(a))
+            .flat_map(get_visitor)
             .collect::<Vec<_>>();
         let snapshot = Snapshot::try_new(table_root, store.clone(), config, version).await?;
         let files = snapshot.files(store, &mut visitors)?.try_collect().await?;
@@ -469,7 +469,7 @@ impl EagerSnapshot {
         let mut visitors = self
             .tracked_actions
             .iter()
-            .flat_map(|a| get_visitor(a))
+            .flat_map(get_visitor)
             .collect::<Vec<_>>();
 
         let mut schema_actions: HashSet<_> =
@@ -629,7 +629,7 @@ impl EagerSnapshot {
         let mut visitors = self
             .tracked_actions
             .iter()
-            .flat_map(|a| get_visitor(a))
+            .flat_map(get_visitor)
             .collect::<Vec<_>>();
         let mut schema_actions: HashSet<_> =
             visitors.iter().flat_map(|v| v.required_actions()).collect();

crates/core/src/kernel/snapshot/visitors.rs

@@ -50,7 +50,7 @@ impl AppTransactionVisitor {
         for (key, value) in &self.app_transaction_version {
             clone.insert(key.clone(), value.clone());
         }
-        return clone;
+        clone
     }
 }
 

crates/core/src/operations/cast.rs

@@ -230,7 +230,7 @@ mod tests {
         assert_eq!(result.fields().len(), 1);
         let delta_type: DeltaDataType = result.fields()[0].data_type().try_into().unwrap();
         assert_eq!(delta_type, DeltaDataType::STRING);
-        assert_eq!(result.fields()[0].is_nullable(), true);
+        assert!(result.fields()[0].is_nullable());
     }
 
     #[test]
@@ -282,7 +282,7 @@ mod tests {
             delta_type,
             DeltaDataType::Array(Box::new(DeltaArrayType::new(DeltaDataType::STRING, false)))
         );
-        assert_eq!(result.fields()[0].is_nullable(), true);
+        assert!(result.fields()[0].is_nullable());
     }
 
     #[test]

crates/core/src/operations/optimize.rs

@@ -1345,7 +1345,7 @@ pub(super) mod zorder {
                     "+-----+-----+-----------+",
                 ];
 
-                let expected = vec![expected_1, expected_2, expected_3];
+                let expected = [expected_1, expected_2, expected_3];
 
                 let indices = Int32Array::from(shuffled_indices().to_vec());
                 let shuffled_columns = batch

crates/core/src/operations/transaction/application.rs

@@ -97,7 +97,7 @@ mod tests {
             .with_partition_columns(["modified"])
             .with_commit_properties(
                 CommitProperties::default()
-                    .with_application_transaction(Transaction::new(&"my-app", 1)),
+                    .with_application_transaction(Transaction::new("my-app", 1)),
             )
             .await
             .unwrap();
@@ -113,7 +113,7 @@ mod tests {
             .write(vec![get_record_batch(None, false)])
             .with_commit_properties(
                 CommitProperties::default()
-                    .with_application_transaction(Transaction::new(&"my-app", 2)),
+                    .with_application_transaction(Transaction::new("my-app", 2)),
             )
             .await
             .unwrap();
@@ -123,7 +123,7 @@ mod tests {
             .write(vec![get_record_batch(None, false)])
             .with_commit_properties(
                 CommitProperties::default()
-                    .with_application_transaction(Transaction::new(&"my-app", 3)),
+                    .with_application_transaction(Transaction::new("my-app", 3)),
             )
             .await;
 

crates/core/src/operations/writer.rs

@@ -613,15 +613,15 @@ mod tests {
 
         match result {
             Ok(_) => {
-                assert!(false, "Should not have successfully written");
+                panic!("Should not have successfully written");
             }
             Err(e) => {
                 match e {
                     DeltaTableError::SchemaMismatch { .. } => {
                         // this is expected
                     }
                     others => {
-                        assert!(false, "Got the wrong error: {others:?}");
+                        panic!("Got the wrong error: {others:?}");
                     }
                 }
             }

crates/core/src/protocol/checkpoints.rs

@@ -302,7 +302,7 @@ fn parquet_bytes_from_state(
         state
             .app_transaction_version()
             .map_err(|_| CheckpointError::MissingActionType("txn".to_string()))?
-            .map(|txn| Action::Txn(txn)),
+            .map(Action::Txn),
     )
     // removes
     .chain(tombstones.iter().map(|r| {

crates/core/src/table/state_arrow.rs

@@ -572,7 +572,7 @@ impl DeltaTableState {
                 // into StructArrays, until it is consolidated into a single array.
                 columnar_stats = columnar_stats
                     .into_iter()
-                    .group_by(|col_stat| {
+                    .chunk_by(|col_stat| {
                         if col_stat.path.len() < level {
                             col_stat.path.clone()
                         } else {

crates/core/src/writer/json.rs

@@ -600,11 +600,8 @@ mod tests {
                 }
             );
 
-            match writer.write(vec![second_data]).await {
-                Ok(_) => {
-                    assert!(false, "Should not have successfully written");
-                }
-                _ => {}
+            if writer.write(vec![second_data]).await.is_ok() {
+                panic!("Should not have successfully written");
             }
         }
 

crates/core/src/writer/record_batch.rs

@@ -566,7 +566,7 @@ mod tests {
         let mut writer = RecordBatchWriter::for_table(&table).unwrap();
         let partitions = writer.divide_by_partition_values(&batch).unwrap();
 
-        let expected_keys = vec![
+        let expected_keys = [
             String::from("modified=2021-02-01"),
             String::from("modified=2021-02-02"),
         ];
@@ -710,15 +710,15 @@ mod tests {
 
             match result {
                 Ok(_) => {
-                    assert!(false, "Should not have successfully written");
+                    panic!("Should not have successfully written");
                 }
                 Err(e) => {
                     match e {
                         DeltaTableError::SchemaMismatch { .. } => {
                             // this is expected
                         }
                         others => {
-                            assert!(false, "Got the wrong error: {others:?}");
+                            panic!("Got the wrong error: {others:?}");
                         }
                     }
                 }

crates/core/tests/command_merge.rs

@@ -14,9 +14,9 @@ use deltalake_core::protocol::SaveMode;
 use deltalake_core::{open_table, DeltaOps, DeltaResult, DeltaTable, DeltaTableError};
 use std::sync::Arc;
 
-async fn create_table(table_uri: &String, partition: Option<Vec<&str>>) -> DeltaTable {
+async fn create_table(table_uri: &str, partition: Option<Vec<&str>>) -> DeltaTable {
     let table_schema = get_delta_schema();
-    let ops = DeltaOps::try_from_uri(table_uri.clone()).await.unwrap();
+    let ops = DeltaOps::try_from_uri(table_uri).await.unwrap();
     let table = ops
         .create()
         .with_columns(table_schema.fields().clone())
@@ -25,7 +25,7 @@ async fn create_table(table_uri: &String, partition: Option<Vec<&str>>) -> Delta
         .expect("Failed to create table");
 
     let schema = get_arrow_schema();
-    return write_data(table, &schema).await;
+    write_data(table, &schema).await
 }
 
 fn get_delta_schema() -> StructType {
@@ -49,11 +49,11 @@ fn get_delta_schema() -> StructType {
 }
 
 fn get_arrow_schema() -> Arc<ArrowSchema> {
-    return Arc::new(ArrowSchema::new(vec![
+    Arc::new(ArrowSchema::new(vec![
         Field::new("id", DataType::Utf8, true),
         Field::new("value", DataType::Int32, true),
         Field::new("event_date", DataType::Utf8, true),
-    ]));
+    ]))
 }
 
 async fn write_data(table: DeltaTable, schema: &Arc<ArrowSchema>) -> DeltaTable {
@@ -108,15 +108,15 @@ fn create_test_data() -> (DataFrame, DataFrame) {
     )
     .unwrap();
     let df2 = ctx.read_batch(batch).unwrap();
-    return (df1, df2);
+    (df1, df2)
 }
 
 async fn merge(
     table: DeltaTable,
     df: DataFrame,
     predicate: Expr,
 ) -> DeltaResult<(DeltaTable, MergeMetrics)> {
-    return DeltaOps(table)
+    DeltaOps(table)
         .merge(df, predicate)
         .with_source_alias("source")
         .with_target_alias("target")
@@ -133,7 +133,7 @@ async fn merge(
                 .set("event_date", col("source.event_date"))
         })
         .unwrap()
-        .await;
+        .await
 }
 
 #[tokio::test]
@@ -142,7 +142,7 @@ async fn test_merge_concurrent_conflict() {
     let tmp_dir = tempfile::tempdir().unwrap();
     let table_uri = tmp_dir.path().to_str().to_owned().unwrap();
 
-    let table_ref1 = create_table(&table_uri.to_string(), Some(vec!["event_date"])).await;
+    let table_ref1 = create_table(table_uri, Some(vec!["event_date"])).await;
     let table_ref2 = open_table(table_uri).await.unwrap();
     let (df1, df2) = create_test_data();
 
@@ -165,7 +165,7 @@ async fn test_merge_concurrent_different_partition() {
     let tmp_dir = tempfile::tempdir().unwrap();
     let table_uri = tmp_dir.path().to_str().to_owned().unwrap();
 
-    let table_ref1 = create_table(&table_uri.to_string(), Some(vec!["event_date"])).await;
+    let table_ref1 = create_table(table_uri, Some(vec!["event_date"])).await;
     let table_ref2 = open_table(table_uri).await.unwrap();
     let (df1, df2) = create_test_data();
 
@@ -177,7 +177,7 @@ async fn test_merge_concurrent_different_partition() {
 
     // TODO: Currently it throws a Version mismatch error, but the merge commit was successfully
     // This bug needs to be fixed, see pull request #2280
-    assert!(matches!(result.as_ref().is_ok(), true));
+    assert!(result.as_ref().is_ok());
 }
 
 #[tokio::test]
@@ -186,7 +186,7 @@ async fn test_merge_concurrent_with_overlapping_files() {
     let tmp_dir = tempfile::tempdir().unwrap();
     let table_uri = tmp_dir.path().to_str().to_owned().unwrap();
 
-    let table_ref1 = create_table(&table_uri.to_string(), None).await;
+    let table_ref1 = create_table(table_uri, None).await;
     let table_ref2 = open_table(table_uri).await.unwrap();
     let (df1, _df2) = create_test_data();
 

crates/core/tests/integration_datafusion.rs

@@ -114,7 +114,7 @@ mod local {
         for batch in batches {
             table = DeltaOps(table)
                 .write(vec![batch])
-                .with_save_mode(save_mode.clone())
+                .with_save_mode(save_mode)
                 .await
                 .unwrap();
         }