-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce package size #144
Reduce package size #144
Conversation
Unsure about which tasks in the GitHub CI workflow actually need to include the |
Lets try it on CI. |
Ah I am pretty sure you forgot the --no-default-features flag a few times. |
5151056
to
12b5564
Compare
I have force pushed after adding all |
12b5564
to
a8982c6
Compare
With the manual dispatch enabled everyone would be able to run the CI workflow on demand on development branches. |
5e1593c
to
5f5009e
Compare
5f5009e
to
2719a0b
Compare
Now it should work: https://github.com/uklotzde/hidapi-rs/actions/runs/7682363490 |
Thx for the contribution. To be honest I actually learned something new about cargo this time. I had no idea you could manually control what files were included when it packages source files. I always thought it did something weird specific to VCS system like git (which would be strange), but now I know better. |
The crate package does not need to include all files. Especially not everything in /etc/hidapi.
Before
Packaged 276 files, 2.2MiB (384.3KiB compressed)
After
Packaged 65 files, 472.4KiB (116.4KiB compressed)