Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce package size #144

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Reduce package size #144

merged 3 commits into from
Jan 28, 2024

Conversation

uklotzde
Copy link
Contributor

The crate package does not need to include all files. Especially not everything in /etc/hidapi.

Before

Packaged 276 files, 2.2MiB (384.3KiB compressed)

After

Packaged 65 files, 472.4KiB (116.4KiB compressed)

@uklotzde
Copy link
Contributor Author

Unsure about which tasks in the GitHub CI workflow actually need to include the cargo package step for verification.

@ruabmbua
Copy link
Owner

Lets try it on CI.

@ruabmbua
Copy link
Owner

Ah I am pretty sure you forgot the --no-default-features flag a few times.

@uklotzde
Copy link
Contributor Author

Ah I am pretty sure you forgot the --no-default-features flag a few times.

I have force pushed after adding all --no-default-features arguments.

@uklotzde
Copy link
Contributor Author

With the manual dispatch enabled everyone would be able to run the CI workflow on demand on development branches.

@uklotzde
Copy link
Contributor Author

@ruabmbua ruabmbua merged commit 6bbbbe2 into ruabmbua:master Jan 28, 2024
9 checks passed
@ruabmbua
Copy link
Owner

Thx for the contribution. To be honest I actually learned something new about cargo this time. I had no idea you could manually control what files were included when it packages source files. I always thought it did something weird specific to VCS system like git (which would be strange), but now I know better.

@uklotzde uklotzde deleted the cargo-package branch January 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants