Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual backport workspace permission tab #333

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Apr 17, 2024

Description

Manual backport opensearch-project#6378 to pr-integr

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…earch-project#6378)

* Allow workspace update with partial attirbutes

Signed-off-by: Lin Wang <[email protected]>

* Add permissions tab for workspace creator and update page

Signed-off-by: Lin Wang <[email protected]>

* Add change log for adding permission tab

Signed-off-by: Lin Wang <[email protected]>

* Optimize permissions to permissions settings convertation

Signed-off-by: Lin Wang <[email protected]>

* Address PR comments

Signed-off-by: Lin Wang <[email protected]>

* Update comments for getPermissionModeId

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
@wanglam wanglam force-pushed the backport-workspace-cerate-and-permission-tab branch from 33768ac to ca14f60 Compare April 17, 2024 08:56
@wanglam wanglam marked this pull request as ready for review April 17, 2024 09:14
@wanglam wanglam requested a review from SuZhou-Joe as a code owner April 17, 2024 09:14
@wanglam wanglam merged commit d5bda77 into ruanyl:workspace-pr-integr Apr 17, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant