Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_node.block_node does not handle numblocks #208

Closed
dvandersluis opened this issue Sep 15, 2021 · 0 comments · Fixed by #209
Closed

send_node.block_node does not handle numblocks #208

dvandersluis opened this issue Sep 15, 2021 · 0 comments · Fixed by #209

Comments

@dvandersluis
Copy link
Member

If a MethodDispatchNode has a block node as its parent, node.block_node returns that parent block node. However, if it's a numblock, node.block_node returns nil.
@dvandersluis dvandersluis changed the title send_node.block_node does not handle numblocks send_node.block_node does not handle numblocks Sep 15, 2021
dvandersluis added a commit to dvandersluis/rubocop-ast that referenced this issue Sep 15, 2021
@dvandersluis
[Fix rubocop#208] Update MethodDispatchNode#block_literal? to retur…
f9ff82b 
…n true for `numblock`s.
@dvandersluis dvandersluis mentioned this issue Sep 15, 2021
Merged
dvandersluis added a commit to dvandersluis/rubocop-ast that referenced this issue Sep 15, 2021
@dvandersluis
[Fix rubocop#208] Update MethodDispatchNode#block_literal? to retur…
079352d 
…n true for `numblock`s.
marcandre pushed a commit that referenced this issue Sep 28, 2021
@dvandersluis @marcandre
[Fix #208] Update MethodDispatchNode#block_literal? to return true …
ceb3d1b 
…for `numblock`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dvandersluis