Update from Parser::Ruby28 to Parser::Ruby30 for Ruby 3.0 parser
#121
Conversation
|
This PR should be synchronized with rubocop/rubocop#8785 for the successful build. |
|
@bbatsov @marcandre Can you please release RuboCop AST with this PR merged to resolve rubocop/rubocop#8785? |
lib/rubocop/ast/processed_source.rb
Outdated
| when 2.8 | ||
| require 'parser/ruby28' | ||
| Parser::Ruby28 | ||
| when 3.0 |
There was a problem hiding this comment.
could we have when 2.8, 3.0 for compatibility?
There was a problem hiding this comment.
Ah, I get it. In the future, the syntax of Ruby 2.8 and Ruby 3.0 may be dissociated, but I think they are almost the same now. It seems better that both are still supported as migration path. I updated this one.
There was a problem hiding this comment.
Well, this way we are compatible with older rubocop who know about 2.8 and not about 3.0. There won't be an actual Ruby 2.8 afaik.
Parser 2.7.1.5 includes whitequark/parser#729 and this PR updates from `Parser::Ruby28` to `Parser::Ruby30` for Ruby 3.0 parser.
|
And yes, I will make a release shortly, I would like to also merge 2 other PRs too. |
koic
force-pushed
the
update_from_28_to_30_parser
branch
from
d84f39d to
d466792
Compare
|
Released 0.5.0 👍 |
|
Thank you for your quick releasing! |
Parser 2.7.1.5 includes whitequark/parser#729 and this PR updates from
Parser::Ruby28toParser::Ruby30for Ruby 3.0 parser.