Enable BlockNode#argument_list for numblocks.

[dvandersluis]

Follows #154 (I'll rebase away that commit once merged).

numblocks now return an array of ArgNodes from BlockNode#argument_list, and BlockNode#arguments? is true for numblocks.

[dvandersluis]

@marcandre you mentioned that maybe arguments? should be true for a numblock but now I think this is a bad idea. A whole bunch of cops assume arguments? mean that there are explicit arguments, and this will break expectations. I'm going to revert that part.

[marcandre]

Sounds good. I'm curious if all of these errors are genuine, or if some cops are just not numblock aware.

Maybe we should have a method accepts_arguments? (or arity? or something)?

[dvandersluis]

I think maybe most cops are not numblock aware. There was one actual test failure, but then when I was looking at it, I noticed a lot of places use arguments? to determine how to autocorrect (which means that if numblock arguments count, we'll get some weird autocorrect, which is why I thought we should leave it as is).

Out of curiosity, what's the procedure for changing something that breaks rubocop's tests?

[marcandre]

Out of curiosity, what's the procedure for changing something that breaks rubocop's tests?

Ideally we make the main gem work first, then we can bump the minimum main gem we fully support in the CI specs and builds are always good...

[dvandersluis]

@marcandre this is rebased now.

[marcandre]

I opened rubocop/rubocop#9091...

[marcandre]

Released as 1.2.0, thanks! 👍

[dvandersluis]

Thanks @marcandre! ❤️