Add Node classes for assignment types #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is available I have some cops I'd like to update to make more simple. 😄 |
|
Great work 🎉 PR is great as is, but could you also update |
marcandre
approved these changes
Aug 12, 2021
dvandersluis
force-pushed
the
assignment-nodes
branch
from
5c5edc0 to
fac4004
Compare
|
@marcandre absolutely! I actually had that file open to use as a reference but forgot to update the nodes 😅 Fixed now! |
|
Released 1.10.1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nodes with a mostly unified interface for
lvasgn,ivasgn,cvasgn,gvasgn,casgn,op-asgn,and-asgnandor-asgnnodes.The idea here is that we have a lot of repeated boilerplate in some cops to handle assignment nodes that are mostly but not completely the same. This will allow all assignment nodes to respond to
nameandexpressionregardless of the node type.I didn't create a node class for
masgnbecause that works differently than everything else and I'm not exactly sure what we'd want there as of yet.