Add ragexp_dot? method to RuboCop::AST::Token.
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up #rubocop/rubocop#10798. This PR adds `ragexp_dot?` method to `RuboCop::AST::Token`.
8 tasks
|
You've got a typo in the commit message - ragex -> regex. |
marcandre
reviewed
Jul 9, 2022
|
Thanks @koic . |
|
Released 1.19.0, thanks! |
|
@marcandre @bbatsov Thank you! |
8 tasks
|
|
|
True. Should we rename it? We could add an alias for compatibility, but I'm fine with releasing an updated version with just the corrected name. |
|
Yeah, I think it's widely not used yet, so I think it's an acceptable breaking change. I will open a PR. |
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Jul 10, 2022
…xp_dots` Follow up rubocop#235 (comment). This PR renames `RuboCop::AST::Token#regexp_dot?` to `RuboCop::AST::Token#regexp_dots` It's been determined that it doesn't need to be an alias because it's the API that has just been released and isn't widespread.
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Jul 10, 2022
…xp_dots` Follow up rubocop#235 (comment). This PR renames `RuboCop::AST::Token#regexp_dot?` to `RuboCop::AST::Token#regexp_dots`. It's been determined that it doesn't need to be an alias because it's the API that has just been released and isn't widespread.
|
I've just opened #236. |
marcandre
pushed a commit
that referenced
this pull request
Jul 10, 2022
…xp_dots` Follow up #235 (comment). This PR renames `RuboCop::AST::Token#regexp_dot?` to `RuboCop::AST::Token#regexp_dots`. It's been determined that it doesn't need to be an alias because it's the API that has just been released and isn't widespread.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 11, 2022
Follow up rubocop/rubocop-ast#235. This PR uses `RuboCop::AST::Token#regexp_dots?` instead of a custom logic. Also, `range_nodes` is only needed for autocorrection, so it's not needed most of the time. Therefore, the timing to calculate `range_nodes` is adjusted from `on_new_investigation` to memoization in the autocorrection logic by this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #rubocop/rubocop#10798.
This PR adds
ragexp_dot?method toRuboCop::AST::Token.