Handle anonymous splats in MlhsNode
#340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: rubocop/rubocop#13505 I checked what the cop was previously expecting here, before rubocop/rubocop#13422
|
Agreed, thanks! Released as 1.36.2 |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Nov 27, 2024
Related to rubocop#13505 The fix was applied in rubocop/rubocop-ast#340 but it still makes sense to test here as well
8 tasks
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Nov 27, 2024
The fix was applied in rubocop/rubocop-ast#340 but it still makes sense to test here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: rubocop/rubocop#13505
I checked what the cop was previously expecting here, before rubocop/rubocop#13422
I'm not sure if a
splatmakes much sense here, but nil seems even more unexpected.cc @dvandersluis