Add Node#any_block_type? to determine if a node is either a block or numblock
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was originally envisioned as Especially, |
|
I was also going to say |
marcandre
reviewed
Jan 22, 2025
|
Thanks! ❤️ |
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Jan 27, 2025
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
Jan 27, 2025
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Jan 27, 2025
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many instances where you just want to know if it's a block and don't care about what type it is: https://github.com/search?q=org%3Arubocop+%2Fblock.*numblock%2F&type=code
Should
itblockbe added, most of these will need to add yet another block type. With this, they can instead use this.I had a bit of trouble choosing a good name. Maybe you have a better one to use?