Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BreakNode / ReturnNode / NextNode: Multiple fixes #70

Closed
wants to merge 1 commit into from
Closed

BreakNode / ReturnNode / NextNode: Multiple fixes #70

wants to merge 1 commit into from

Conversation

marcandre
Copy link
Contributor

@marcandre marcandre commented Jul 18, 2020 •
edited
Loading

This PR:

  • fixes return by not including MethodDispatchNode (since it is not a method dispatch). Most methods would return nonsense (e.g. method_call could be nil or whatever the second argument was)
  • same for break, plus fixes argument handling
  • adds NextNode

next, break and return are very similar, the only difference being how far back they leave the current scope.

@marcandre marcandre self-assigned this Jul 18, 2020
@marcandre marcandre closed this Jul 18, 2020
@marcandre marcandre changed the title BreakNode: Fix arguments BreakNode / ReturnNode / NextNode: Multiple fixes Jul 18, 2020
@marcandre
Copy link
Contributor Author

marcandre commented Jul 18, 2020 •
edited
Loading

Moving to #71

@marcandre marcandre mentioned this pull request Jul 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcandre marcandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcandre