Add Parser::Source::Range#line_span
#84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen about 20 occurrences of
range.{first}line..{.}range.last_line
or calls toline_range(node)
(defined inutil.rb
)I feel the name
line_span
is more descriptive and is less confusing withSource::Buffer#line_range
which returns a range of columns for the given line.I notice that there currently are no extension to
parser
's classes, but this one seems reasonable.The result can be particularly useful when dealing with comments, say with
each_comment_in_lines
of #83