Support right hand assignment #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports right hand assignment for Ruby 2.8.0-dev (Ruby 3.0). whitequark/parser#682 ## `mrasgn` vs `masgn` `mrasgn` has the same structure as `masgn` except that the child nodes are reversed. So this PR adds `mrasgn` to the same constant as `masgn`. ### `mrasign` ```console % ruby-parse -e '13.divmod(5) => a, b' warning: parser/current is loading parser/ruby28, which recognizes warning: 2.8.0-dev-compliant syntax, but you are running 2.8.0. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. (mrasgn (send (int 13) :divmod (int 5)) (mlhs (lvasgn :a) (lvasgn :b))) ``` ### `masign` ```console % ruby-parse -e 'a, b = 13.divmod(5)' warning: parser/current is loading parser/ruby28, which recognizes warning: 2.8.0-dev-compliant syntax, but you are running 2.8.0. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. (masgn (mlhs (lvasgn :a) (lvasgn :b)) (send (int 13) :divmod (int 5))) ``` ## `rasgn` `rasgn` has the same structure as `mrasgn` without `mlhs`. So this PR adds `rasgn` to the same constant as `mrasgn`. ```console % ruby-parse -e '13.divmod(5) => a' warning: parser/current is loading parser/ruby28, which recognizes warning: 2.8.0-dev-compliant syntax, but you are running 2.8.0. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. (rasgn (send (int 13) :divmod (int 5)) (lvasgn :a)) ```
|
Looks good, thanks! |
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Aug 4, 2020
I wrote rubocop#89's changelog entry in the released section by mistake. Also an expression of the changelog entry has been tweaked.
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Aug 4, 2020
I wrote rubocop#89's changelog entry in the released section by mistake. This PR tweaks the changelog entry.
Merged
bbatsov
pushed a commit
that referenced
this pull request
Aug 4, 2020
I wrote #89's changelog entry in the released section by mistake. This PR tweaks the changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports right hand assignment for Ruby 2.8.0-dev (Ruby 3.0).
whitequark/parser#682
mrasgnvsmasgnmrasgnhas the same structure asmasgnexcept that the child nodes are reversed. So this PR addsmrasgnto the same constant asmasgn.mrasignmasignrasgnrasgnhas the same structure asmrasgnwithoutmlhs.So this PR adds
rasgnto the same constant asmrasgn.