Fix a rubocop offense #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a rubocop offense for `InternalAffairs/UndefinedConfig`
```
❯ bundle exec rubocop
Inspecting 50 files
...................C..............................
Offenses:
lib/rubocop/cop/capybara/rspec/have_selector.rb:81:30: C: InternalAffairs/UndefinedConfig: DefaultSelector is not defined in the configuration for Capybara/RSpec/HaveSelector in config/default.yml.
cop_config.fetch('DefaultSelector', 'css')
^^^^^^^^^^^^^^^^^
50 files inspected, 1 offense detected
```
|
So we have to eat our own dogfood? Does this make sense? We have no capybara code here. I imagine the same will hit rubocop-minitest and rubocop-md, and rubocop-factory_bot, and other. It’s for rubocop itself and rubocop-rspec where this makes sense. It’s an internal cop, shouldn’t it be looking in config/default.yml for this? |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 19, 2024
Going through the default config is fine for RuboCop itself but extensions need to inject their config for RuboCop to pick them up. This makes it necessary to load the extension, even if the extension itself doesn't use it, like `rubocop-rails` or `rubocop-capybara`. Instead just load config/default.yml from `Dir.pwd` in isolation and use just that. This would make rubocop/rubocop-capybara#133 and rubocop/rubocop-rails@288c7ce unnecessary I tested this against a bunch of extensions and the cop seems to continue its job. It also fixes a false positive in `rubocop-factory_bot`
8 tasks
|
Sounds reasonable, I openend rubocop/rubocop#13141 which would make this PR unnessesary. Let me know if something in that PR looks strange. It does indeed affect |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 20, 2024
Going through the default config is fine for RuboCop itself but extensions need to inject their config for RuboCop to pick them up. This makes it necessary to load the extension, even if the extension itself doesn't use it, like `rubocop-rails` or `rubocop-capybara`. Instead just load config/default.yml from `Dir.pwd` in isolation and use just that. This would make rubocop/rubocop-capybara#133 and rubocop/rubocop-rails@288c7ce unnecessary I tested this against a bunch of extensions and the cop seems to continue its job. It also fixes a false positive in `rubocop-factory_bot`
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 20, 2024
Going through the default config is fine for RuboCop itself but extensions need to inject their config for RuboCop to pick them up. This makes it necessary to load the extension, even if the extension itself doesn't use it, like `rubocop-rails` or `rubocop-capybara`. Instead just load config/default.yml from `Dir.pwd` in isolation and use just that. This would make rubocop/rubocop-capybara#133 and rubocop/rubocop-rails@288c7ce unnecessary I tested this against a bunch of extensions and the cop seems to continue its job. It also fixes a false positive in `rubocop-factory_bot`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a rubocop offense for
InternalAffairs/UndefinedConfigBefore submitting the PR make sure the following are checked:
main(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).