-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DEPRECATED: global use of must_equal from ... Use _(obj).must_equal instead. This will fail in Minitest 6.
#60
Labels
enhancement
New feature or request
Comments
I think it is reasonable to respond to official warnings. |
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 5, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
8 tasks
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 5, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 5, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 6, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 6, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 6, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 6, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 6, 2020
To check against deprecated global expectations. These will be removed in Minitest 6. Closes rubocop#60
koic
added a commit
that referenced
this issue
Mar 7, 2020
[Fix #60] Add new cop `Minitest/GlobalExpectations`
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this issue
Dec 17, 2022
The cops below belong to linting, not style preference, so make set the severity to warning. The following emulates warnings for deprecated APIs: - Minitest/GlobalExpectations (rubocop#60) The following suggests incorrect usage of APIs: - Minitest/AssertRaisesWithRegexpArgument: - Minitest/AssertWithExpectedArgument: - Minitest/SkipEnsure: - Minitest/UnreachableAssertion:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
While I'm working on googleapis/google-cloud-ruby#4884 , I've found that to prepare Ruby 3 keyword arguments support, minitest will require minitest/minitest#824 . I think it would mean the newer version of minitest will support Ruby 3.
On the other hand, gems under
google-cloud-ruby
repository lock the minitest version to use 5.11 or lower because minitest 5.12 showsDEPRECATED: global use of must_equal from must_equal.rb:28. Use _(obj).must_equal instead. This will fail in Minitest 6.
Refer: https://github.com/seattlerb/minitest/blob/master/History.rdoc#label-5.12.0+-2F+2019-09-22I'm looking for some way to address this warning automatically to allow bump minitest version when it is ready to support Ruby 3 keyword arguments.
Describe the solution you'd like
It would be appreciated
rubocop-minitest
gem auto-corrects this warning.Describe alternatives you've considered
Rewrite the test code by myself.
Additional context
Here are the steps to reproduce.
DEPRECATED: global use of must_equal from must_equal.rb:28. Use _(obj).must_equal instead. This will fail in Minitest 6.
The text was updated successfully, but these errors were encountered: