[Fix #157] Add new Minitest/EmptyLineBeforeAssertionMethods cop
#163
Conversation
config/default.yml
Outdated
| @@ -99,6 +99,11 @@ Minitest/AssertWithExpectedArgument: | |||
| Safe: false | |||
| VersionAdded: '0.11' | |||
|
|
|||
| Minitest/EmptyLinesBeforeAssertionMethod: | |||
There was a problem hiding this comment.
Would EmptyLineBeforeAssertionMethod (no plural) be better?
There was a problem hiding this comment.
Yeah, I was wondering about the name of this cop. I've renamed it to Minitest/EmptyLineBeforeAssertionMethods.
There was a problem hiding this comment.
Thinking about this again, I wonder if talking about line/lines is too specific, and the name should better convey the intention.
This is closely tied to Arrange-Act-Assert or the Four Phase Test.
I can't think of a good name yet, but maybe something along the lines of SeparateAssertionPhase or DistinctAssertions...
There was a problem hiding this comment.
@andyw8 I was second thoughts about this cop name. But I will name it as Minitest/EmptyLineBeforeAssertionMethods because the RuboCop core has many similar names.
The attractive candidate SeparateAssertionPhase has been included as the cop document description.
koic
changed the title
Minitest/EmptyLinesBeforeAssertionMethod copMinitest/EmptyLinesBeforeAssertionMethods cop
koic
force-pushed
the
add_new_minitest_empty_line_before_assertion_method_cop
branch
from
e2481fb to
7a9c3d8
Compare
koic
force-pushed
the
add_new_minitest_empty_line_before_assertion_method_cop
branch
from
7a9c3d8 to
c0d5f54
Compare
koic
changed the title
Minitest/EmptyLinesBeforeAssertionMethods copMinitest/EmptyLinesBeforeAssertionMethod cop
koic
changed the title
Minitest/EmptyLinesBeforeAssertionMethod copMinitest/EmptyLineBeforeAssertionMethod cop
koic
force-pushed
the
add_new_minitest_empty_line_before_assertion_method_cop
branch
from
c0d5f54 to
a94e790
Compare
koic
changed the title
Minitest/EmptyLineBeforeAssertionMethod copMinitest/EmptyLineBeforeAssertionMethods cop
koic
force-pushed
the
add_new_minitest_empty_line_before_assertion_method_cop
branch
2 times, most recently
from
5304493 to
e541e62
Compare
test/rubocop/cop/minitest/empty_line_before_assertion_methods_test.rb
Outdated
Show resolved
Hide resolved
Fixes rubocop#157. This PR adds new `Minitest/EmptyLineBeforeAssertionMethods` cop. This cop enforces empty line before assertion method because it separates assertion phase. ```ruby # bad do_something assert_equal(expected, actual) # good do_something assert_equal(expected, actual) ```
koic
force-pushed
the
add_new_minitest_empty_line_before_assertion_method_cop
branch
from
e541e62 to
6d8a9e7
Compare
koic
deleted the
add_new_minitest_empty_line_before_assertion_method_cop
branch
|
@koic Awesome! 🥇 |
Fixes #157.
This PR adds new
Minitest/EmptyLineBeforeAssertionMethodscop.This cop enforces empty line before assertion method.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.