Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #187] Fix an error for Minitest/EmptyLineBeforeAssertionMethods #188

Conversation

koic
Copy link
Member

@koic koic commented Oct 30, 2022

Fixes #187.

This PR fixes an error for Minitest/EmptyLineBeforeAssertionMethods when using method call with block.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_an_error_for_minitest_empty_line_before_assertion_methods branch from 45cb689 to 693ff56 Compare October 30, 2022 23:52
…Methods`

Fixes rubocop#187.

This PR fixes an error for `Minitest/EmptyLineBeforeAssertionMethods`
when using method call with block.
@koic koic changed the title [Fix #817] Fix an error for Minitest/EmptyLineBeforeAssertionMethods [Fix #187] Fix an error for Minitest/EmptyLineBeforeAssertionMethods Oct 31, 2022
@koic koic force-pushed the fix_an_error_for_minitest_empty_line_before_assertion_methods branch from 693ff56 to 1bb5d1b Compare October 31, 2022 00:06
@koic koic merged commit 7864020 into rubocop:master Oct 31, 2022
@koic koic deleted the fix_an_error_for_minitest_empty_line_before_assertion_methods branch October 31, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minitest::EmptyLineBeforeAssertionMethods errors on assertions with block arguments
1 participant