[Fix #118] Fix a false positive for DeletePrefix and DeletePrefix cops
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @koic I think the problem is not in any way related to heredocs. Take any string containing newlines, and you cannot simply replace a call to The only thing that works in general is |
koic
force-pushed
the
fix_false_positive_for_delete_prefix_and_delete_suffix
branch
from
7a499d8 to
1377de1
Compare
|
@avdv Thanks for your feedback. I have rewritten this PR and added |
…Prefix` cops Fixes rubocop#118. Fix a false positive for `Performance/DeletePrefix`, `Performance/DeletePrefix`, `Performance/StartWith`, and `Performance/EndWith` cops when receiver is multiline string.
koic
force-pushed
the
fix_false_positive_for_delete_prefix_and_delete_suffix
branch
from
1377de1 to
f5f560f
Compare
|
Thank you, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118.
Fix a false positive for
Performance/DeletePrefix,Performance/DeletePrefix,Performance/StartWith, andPerformance/EndWithcops when receiver is multiline string.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.