Skip to content

Commit

Permalink
Drop support for Ruby 2.3.
Browse files Browse the repository at this point in the history
This commit drops support for Ruby 2.3 and suppresses the following
`Gemspec/RequiredRubyVersion` offense.

```console
% cd path/to/rubocop-rake
% bundle exec rake
(snip)

Offenses:

rubocop-rake.gemspec:14:32: C: Gemspec/RequiredRubyVersion:
required_ruby_version (2.3, declared in rubocop-rake.gemspec) and
TargetRubyVersion (2.4, which may be specified in .rubocop.yml) should
be equal.
  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

25 files inspected, 1 offense detected
```
  • Loading branch information
koic committed Nov 3, 2020
1 parent 419e82e commit f2f1dd1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
6 changes: 0 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ steps: &steps

jobs:

ruby-2.3:
docker:
- image: circleci/ruby:2.3
<<: *steps

ruby-2.4:
docker:
- image: circleci/ruby:2.4
Expand Down Expand Up @@ -42,7 +37,6 @@ workflows:
version: 2
build:
jobs:
- ruby-2.3
- ruby-2.4
- ruby-2.5
- ruby-2.6
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## master (unreleased)

### Changes

* [#33](https://github.com/rubocop-hq/rubocop-rake/pull/33): Drop support for Ruby 2.3. ([@koic][])

## 0.5.1 (2020-02-14)

### Bug fixes
Expand Down Expand Up @@ -51,3 +55,4 @@

[@pocke]: https://github.com/pocke
[@jaruuuu]: https://github.com/jaruuuu
[@koic]: https://github.com/koic
2 changes: 1 addition & 1 deletion rubocop-rake.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
spec.summary = %q{A RuboCop plugin for Rake}
spec.description = %q{A RuboCop plugin for Rake}
spec.homepage = "https://github.com/rubocop-hq/rubocop-rake"
spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
spec.licenses = ['MIT']

spec.metadata["allowed_push_host"] = "https://rubygems.org"
Expand Down

0 comments on commit f2f1dd1

Please sign in to comment.