-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and provide a reference implementation on RSpec DSL aliases configuration in third-party gems #1077
Closed
3 of 4 tasks
Labels
Comments
This was referenced Nov 6, 2020
pirj
added a commit
to pirj/action_policy
that referenced
this issue
Nov 8, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 - palkan#103
pirj
added a commit
to pirj/action_policy
that referenced
this issue
Nov 8, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 - palkan#103
2 tasks
pirj
added a commit
to pirj/test-prof
that referenced
this issue
Nov 9, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 Sibling pull requests: - palkan/action_policy#138
2 tasks
pirj
added a commit
to pirj/test-prof
that referenced
this issue
Nov 9, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 Sibling pull requests: - palkan/action_policy#138
pirj
added a commit
to pirj/test-prof
that referenced
this issue
Nov 9, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 Sibling pull requests: - palkan/action_policy#138
pirj
added a commit
to pirj/action_policy
that referenced
this issue
Nov 17, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 - palkan#103
pirj
added a commit
to pirj/test-prof
that referenced
this issue
Nov 17, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 Sibling pull requests: - palkan/action_policy#138
palkan
pushed a commit
to palkan/action_policy
that referenced
this issue
Nov 18, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 - #103
pirj
added a commit
to pirj/test-prof
that referenced
this issue
Nov 18, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 Sibling pull requests: - palkan/action_policy#138
palkan
pushed a commit
to test-prof/test-prof
that referenced
this issue
Nov 18, 2020
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 Sibling pull requests: - palkan/action_policy#138
pirj
added a commit
that referenced
this issue
Nov 18, 2020
4 tasks
pirj
added a commit
that referenced
this issue
Nov 18, 2020
pirj
added a commit
that referenced
this issue
Nov 18, 2020
pirj
added a commit
that referenced
this issue
Nov 18, 2020
pirj
added a commit
that referenced
this issue
Nov 18, 2020
pirj
added a commit
that referenced
this issue
Nov 18, 2020
pirj
added a commit
that referenced
this issue
Nov 19, 2020
This was referenced Oct 3, 2021
andrebarretofv
added a commit
to andrebarretofv/action_policy
that referenced
this issue
Jul 10, 2024
Previously, RuboCop RSpec failed to detect RSpec aliases. A number of cops were failing false offences, and some cops were unable to lint, as they were skipping locally defined RSpec aliases taking them for arbitrary blocks and method calls. See: - rubocop/rubocop-rspec#1077 - rubocop/rubocop-rspec#956 - palkan/action_policy#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #956 being released as part of RuboCop RSpec 2.0, this opens a possibility for third-party gems to supplement the default RSpec aliases configuration with those aliases that they introduce.
The purpose of this is to push the responsibility of configuring RSpec alias detection to third-party gems to avoid potential conflicts, avoid an excessive default list of aliases, and reduce the maintenance burden on us.
TODO:
Notable examples are:
cancancan
'sis_able_to
, see: RSpec/EmptyExampleGroup raises when using only shared examples in a context #884action_policy
'sdescribe_rule
,failed
,succeed
, see: Make RSpec describe_rule DRY palkan/action_policy#103, pull: Add RuboCop RSpec support palkan/action_policy#138test-prof
'slet_it_be
/before_all
, pull: Add RuboCop RSpec support test-prof/test-prof#199rspec-its
'sits
saharspec
'sits_map
,its_block
,its_call
, see: RSpec/SharedContext: needs CustomIncludeMethods setting #975pundit
'spermissions
(alsorole
was mentioned), see: Add a spec for the project policy openSUSE/open-build-service#5878, Users should be able to globally configure example group and includes language #333- seeminglyrspec-rails
'ssetup
hook Allow to catch RSpec/ExpectInHook offenses in the setup block #835setup
comes from the underlying MinitestProposed solution
https://docs.rubocop.org/rubocop/1.2/configuration.html#inheriting-configuration-from-a-dependency-gem
Third party gem's
rubocop_rspec_alias_config.yml
:Third-party gem's README.md:
Source of infromation: #333
The text was updated successfully, but these errors were encountered: