-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a false positive for RSpec/RepeatedExampleGroupBody
when pending
or skip
have argument(s).
#1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
||
context 'processed' do | ||
skip 'some reason' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now when I look at it, it seems that there's something wrong, and it's the repeated context title.
Do you mind to make them different?
The example with describe '#load' do
isn't the best reference, it's a miss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try update them to clarify use case.
3252c19
to
e30b0c3
Compare
@pirj Are you happy with this PR as it is? (We can resolve the Changelog conflict on merge). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ng` or `skip` have argument(s).
d0370d6
to
59632d9
Compare
RSpec/RepeatedExampleGroupBody
does not register offenses when example group body isskip
orpending
.But each of them has a same argument, registers offenses.
I thinks this is a false positive.
This PR allows this.
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.VersionAdded
indefault/config.yml
to the next minor version.If you have modified an existing cop's configuration options:
VersionChanged
inconfig/default.yml
to the next major version.