Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --auto-gen-config faster if Metrics/LineLength is disabled #6262

Closed
bquorning opened this issue Sep 10, 2018 · 1 comment
Closed

Make --auto-gen-config faster if Metrics/LineLength is disabled #6262

bquorning opened this issue Sep 10, 2018 · 1 comment
Labels
enhancement

Comments

@bquorning
Copy link
Contributor

When using the --auto-gen-config flag, RuboCop runs through all files twice:

» rubocop --auto-gen-config
Phase 1 of 2: run Metrics/LineLength cop
Created .rubocop_todo.yml.
Phase 2 of 2: run all cops
Created .rubocop_todo.yml.

In .rubocop.yml, I have the Metrics/LineLength cop disabled, so couldn’t that first step be skipped?
@bquorning bquorning changed the title Make --auto-gen-config faster if Metrics/LineLength is disabled anyway. Make --auto-gen-config faster if Metrics/LineLength is disabled Sep 10, 2018
@tom-lord tom-lord mentioned this issue Sep 29, 2018
Merged
@bquorning
Copy link
Contributor Author

Related to #5228 / #5246 /cc @jonas054

tom-lord added a commit to tom-lord/rubocop that referenced this issue Dec 10, 2018
@tom-lord
[FIX rubocop#6262] Spec for desired auto-gen-config behaviour when Li…
2ca4613 
…neLength disabled
tom-lord added a commit to tom-lord/rubocop that referenced this issue Dec 10, 2018
@tom-lord
[FIX rubocop#6262] Skip phase 1 of auto-gen-config when line length c…
2f8999c 
…op disabled
tom-lord added a commit to tom-lord/rubocop that referenced this issue Dec 10, 2018
@tom-lord
[Fix rubocop#6262] Split 'phase 1 skipped' into overridden vs disabled
0fc65b6
tom-lord added a commit to tom-lord/rubocop that referenced this issue Dec 10, 2018
@tom-lord
[FIX rubocop#6262] Update changelog
f7fe3b5
jonas054 added a commit that referenced this issue Dec 11, 2018
@jonas054
Merge pull request #6343 from tom-lord/optimise_auto-gen-config_when_…
9341272 
…Metrics/LineLength_disabled

[Fix #6262] Optimise --auto-gen-config when Metrics/LineLength cop is disabled
Nyangawa pushed a commit to Nyangawa/rubocop that referenced this issue Jan 24, 2019
@tom-lord
[FIX rubocop#6262] Update changelog
739172d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bquorning @Drenmi