Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect autocorrect for Style/RedundantRegexpArgument when the regex contains a single quote. #13616

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

mrzasa
Copy link
Contributor

@mrzasa mrzasa commented Dec 20, 2024

When a regex has only a single quote, /'/ it is autocorrected by Style/RedundantRegexpArgument to ''' which leads to a syntax error.

In this PR I'm escaping the single quote to avoid the issue.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@mrzasa mrzasa force-pushed the fix-quote-escaping branch from 2d3419e to 3174a3d Compare December 20, 2024 21:28
@mrzasa mrzasa marked this pull request as ready for review December 20, 2024 21:28
@mrzasa mrzasa force-pushed the fix-quote-escaping branch from ba2c8a5 to 93441d8 Compare December 21, 2024 18:07
@koic koic merged commit fceb0a1 into rubocop:master Dec 21, 2024
22 checks passed
@koic
Copy link
Member

koic commented Dec 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants