Change Style/RedundantFreeze message
#3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcphillips
reviewed
Dec 1, 2016
| @@ -14,7 +14,7 @@ module Style | |||
| class RedundantFreeze < Cop | |||
| include FrozenStringLiteral | |||
|
|
|||
| MSG = 'Freezing immutable objects is pointless.'.freeze | |||
| MSG = "Do not freeze immutable objects.".freeze | |||
There was a problem hiding this comment.
How about:
Freezing immutable objects has no effect.
That explains the why as well as giving the instruction.
There was a problem hiding this comment.
Or "Do not freeze immutable objects, as freezing them has no effect.".
kmcphillips
approved these changes
Dec 1, 2016
lucasuyezu
force-pushed
the
change_redundant_freeze_message
branch
2 times, most recently
from
2759415 to
1acdb86
Compare
|
@bbatsov Message updated. |
kmcphillips
approved these changes
Dec 6, 2016
|
You've broken the build by changing the style of the string quotes. You'll also need to rebase. |
lucasuyezu
force-pushed
the
change_redundant_freeze_message
branch
from
1acdb86 to
da7d5d8
Compare
|
The build is still failing. |
lucasuyezu
force-pushed
the
change_redundant_freeze_message
branch
from
da7d5d8 to
990ad58
Compare
lucasuyezu
force-pushed
the
change_redundant_freeze_message
branch
from
990ad58 to
3627cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the message for
Style/RedundantFreeze. The new message is less aggressive and is more uniform with other messages in the code base, likeLint/HandleExceptions.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).