[Fix #5409] Fix multiline indent for Style/SymbolArray and Style/Word… #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyerhzm
force-pushed
the
symbol-array-and-word-array-multiline-indent
branch
3 times, most recently
from
03c01af to
e194081
Compare
…le/WordArray autocorrect
flyerhzm
force-pushed
the
symbol-array-and-word-array-multiline-indent
branch
from
e194081 to
e0f3b88
Compare
|
@bbatsov I have check travis-ci errors, all look are travis-ci internal errors. I have already run |
|
👍 |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jan 7, 2018
Follow up of rubocop#5410. This PR fixes the following error on Travis CI. ```console % bundle exec rspec ./spec/project_spec.rb Run options: include {:focus=>true} All examples were filtered out; ignoring {:focus=>true} Randomized with seed 45488 ..............F.F Failures: 1) RuboCop Project changelog entry body ends with a punctuation Failure/Error: expect(bodies).to all(match(/[\.\!]$/)) expected ["Add new `` cop.", "Add new `` cop.", "Add new `` cop.", "Add new `` cop.", "Add new `` cop.", "Add ...nclosed in braces are not noticed.", "Received malformed format string ArgumentError from rubocop."] to all match /[\.\!]$/ object at index 18 failed to match: expected "Fix ``'s false positive with a method call with arguments. ([@pocke][]) " to match /[\.\!]$/ # ./spec/project_spec.rb:174:in `block (5 levels) in <top (required)>' 2) RuboCop Project changelog entry after version 0.14.0 has a link to the contributors at the end Failure/Error: expect(entries).to all(match(/\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/)) expected ["* [rubocop#3666](rubocop#3666): Add new `Naming/UncommunicativeBlockPara...552): `RaiseArgs` allows exception constructor calls with more than one 1 argument. ([@bbatsov][])"] to all match /\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/ object at index 18 failed to match: expected "* [rubocop#5393](rubocop#5393): Fix `Rails/Delegate`'s false positive with a method call with arguments. ([@pocke][]) " to match /\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/ # ./spec/project_spec.rb:123:in `block (5 levels) in <top (required)>' Finished in 1.36 seconds (files took 1.07 seconds to load) 17 examples, 2 failures Failed examples: rspec ./spec/project_spec.rb:173 # RuboCop Project changelog entry body ends with a punctuation rspec ./spec/project_spec.rb:122 # RuboCop Project changelog entry after version 0.14.0 has a link to the contributors at the end ``` https://travis-ci.org/bbatsov/rubocop/jobs/325980721#L1146-L1162
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Jan 7, 2018
Follow up of #5410. This PR fixes the following error on Travis CI. ```console % bundle exec rspec ./spec/project_spec.rb Run options: include {:focus=>true} All examples were filtered out; ignoring {:focus=>true} Randomized with seed 45488 ..............F.F Failures: 1) RuboCop Project changelog entry body ends with a punctuation Failure/Error: expect(bodies).to all(match(/[\.\!]$/)) expected ["Add new `` cop.", "Add new `` cop.", "Add new `` cop.", "Add new `` cop.", "Add new `` cop.", "Add ...nclosed in braces are not noticed.", "Received malformed format string ArgumentError from rubocop."] to all match /[\.\!]$/ object at index 18 failed to match: expected "Fix ``'s false positive with a method call with arguments. ([@pocke][]) " to match /[\.\!]$/ # ./spec/project_spec.rb:174:in `block (5 levels) in <top (required)>' 2) RuboCop Project changelog entry after version 0.14.0 has a link to the contributors at the end Failure/Error: expect(entries).to all(match(/\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/)) expected ["* [#3666](#3666): Add new `Naming/UncommunicativeBlockPara...552): `RaiseArgs` allows exception constructor calls with more than one 1 argument. ([@bbatsov][])"] to all match /\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/ object at index 18 failed to match: expected "* [#5393](#5393): Fix `Rails/Delegate`'s false positive with a method call with arguments. ([@pocke][]) " to match /\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/ # ./spec/project_spec.rb:123:in `block (5 levels) in <top (required)>' Finished in 1.36 seconds (files took 1.07 seconds to load) 17 examples, 2 failures Failed examples: rspec ./spec/project_spec.rb:173 # RuboCop Project changelog entry body ends with a punctuation rspec ./spec/project_spec.rb:122 # RuboCop Project changelog entry after version 0.14.0 has a link to the contributors at the end ``` https://travis-ci.org/bbatsov/rubocop/jobs/325980721#L1146-L1162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5409
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.