Add a rule about send metaprogramming.
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3616,6 +3616,9 @@ resource cleanup when possible. | |||
| * <a name="prefer-public-send"></a> | |||
| Prefer `public_send` over `send` so as not to circumvent `private`/`protected` visibility. | |||
| <sup>[[link](#prefer-public-send)]</sup> | |||
| * <a name="prefer-__send__"></a> | |||
There was a problem hiding this comment.
Add a blank line before the anchor.
|
And I guess you'll submit one more PR about |
|
@bbatsov Isn't the existing rule about I have to think about good (and meaningful) code examples that prove the rules. |
|
Sorry about this. Was a bit distracted when I made my comment. Just remove the |
|
@syndbg ping :-) |
Submitted as requested in rubocop/rubocop#2081
|
@bbatsov Sorry for the delays. Added code examples. Turned out that thinking of good examples for trivial stuff is hard. 🎱 |
|
@bbatsov ping. |
bbatsov
added a commit
that referenced
this pull request
Oct 9, 2015
Add a rule about `send` metaprogramming
|
👍 |
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
Add a rule about `send` metaprogramming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted as requested in rubocop/rubocop#2081