Fix #30 (headers encoding other than ASCII-8BIT) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see comments at: ruby-amqp#30 (comment)
|
Fix is not fully working yet. I am evaluating some improvements. There is still a problem when using deep hashes as headers. |
michaelklishin
added a commit
that referenced
this pull request
Nov 25, 2015
Fix #30 (headers encoding other than ASCII-8BIT)
|
@TomFreudenberg while we can update table encoder/decoder to also handle this, I find the case with nested headers to be very rare. |
|
please check #57 for the fix of nested headers. Hope you like it too. Cheers, P.S.: I am using nested headers ;-) |
michaelklishin
added a commit
that referenced
this pull request
Jan 26, 2017
.pytemplate should be updated instead of the file it generates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see comments at: #30 (comment)