Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api_key_placeholder option #114

Merged
merged 7 commits into from
Feb 24, 2024

Conversation

SofiaSousa
Copy link
Contributor

Related to #113

@SofiaSousa SofiaSousa changed the title Add api_key_placeholder option Add api_key_placeholder option Feb 22, 2024
@dblock
Copy link
Member

dblock commented Feb 24, 2024

Looks great, merging.

Couple of things that I think would make sense as another PR if you're up for it?

  1. I think when the value is set to nil, it should not appear in the form. Same for other values.
  2. We need a reset! for options to clear/revert to default api_key_default_value and other values around each spec.

Btw, interested in co-maintaining this lib? It doesn't see a lot of action. If you are, drop me a note to dblock[at]dblock[dot]org with your rubygems alias and maybe you can make the next release with this feature?

@dblock dblock merged commit cffa0ce into ruby-grape:master Feb 24, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants