use Ostruct#marshal_dump instead of #to_h to support Ruby 1.9.3 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suan
force-pushed
the
ruby_19_swagger_options_fix
branch
from
d5ffbc5 to
dc50c28
Compare
| @@ -5,6 +5,7 @@ | |||
| * Grape-swagger 0.7.2 is no longer supported - [@dblock](https://github.com/dblock). | |||
| * Implemented RuboCop, Ruby-style linter - [@dblock](https://github.com/dblock). | |||
| * [#31](https://github.com/ruby-grape/grape-swagger-rails/pull/31): Support Swagger-UI docExpansion option - [@maruware](https://github.com/maruware). | |||
| * [#32](https://github.com/ruby-grape/grape-swagger-rails/pull/32): Fix a small bug which broke Ruby 1.9.3 compatibility - [@suan](https://github.com/suan). | |||
There was a problem hiding this comment.
This should say Fix Ruby 1.9.3 compatibility.
|
If we're going to reintroduce 1.9.3 compatibility, please add it to .travis.yml and make sure a test breaks without this fix. |
suan
force-pushed
the
ruby_19_swagger_options_fix
branch
from
dc50c28 to
2077dce
Compare
|
@dblock Added 1.9.3 to |
dblock
added a commit
that referenced
this pull request
Oct 7, 2015
use Ostruct#marshal_dump instead of #to_h to support Ruby 1.9.3
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grape-swagger-rails currently breaks on Ruby < 2.0 cause it relies on
OpenStruct#to_h, which is new.OpenStruct#marshal_dumpis equivalent and is backwards compatibleAlso consider adding v1.9.3 to the Travis matrix?