Only dup InheritableValues, remove support for deep_dup #1048
+12
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you please squash these commits? |
Please also see ruby-grape#1034, where StackableValues are only dup'ed (not deep_dup'ed). Other changes: * Add test to reproduce bug ruby-grape#891 * Remove support for deep_dup (no longer used) * Add item to CHANGELOG
toddmazierski
force-pushed
the
only-dup-inheritable-values
branch
from
e5cc168 to
bdb334c
Compare
Done (bdb334c)! |
dblock
added a commit
that referenced
this pull request
Jun 30, 2015
…lues Only dup InheritableValues, remove support for deep_dup
|
Merged, thank you. |
|
You're welcome. Thanks for your help, and all your hard work on Grape! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To fix #891, settings managed with
InheritableValuesare nowduped instead ofdeep_duped. This is a continuation of the change made in #1034 forStackableValues, and the same notes on impact and testing (ex. trying this out in real projects) likely apply!Other Changes
Now that
deep_dupis no longer used, support for it has been removed (lib/backports).Related Issues