-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ruby-2.0 and mustermann19, use mustermann-grape instead #1470
Conversation
Generated by 🚫 danger |
OMG, latest mustermann requires ruby-2.1 or later. |
I say we go for it and drop 2.0. Rails already requires 2.2. |
Does Rails 3 not work with Ruby 2.1? If so we should mention it and |
I release 0.17.0, maybe make a major version increment (replace 0.17.1 -> 0.18.0) with this PR? |
Bump @namusyaka? |
Sorry for the delay. rails-3.2-stable seems like to support ruby 2.1.
Yeah, the major version should be incremented, but I'd like to merge a few things for fixing bugs. |
f01d2bb
to
d606f17
Compare
Just rebased and force pushed. |
You also need to drop rails 3 from appraisals, no? |
@@ -13,11 +13,13 @@ | |||
#### Features | |||
|
|||
* [#1393](https://github.com/ruby-grape/grape/pull/1393): Middleware can be inserted before or after default Grape middleware - [@ridiculous](https://github.com/ridiculous). | |||
* [#1390](https://github.com/ruby-grape/grape/pull/1390): Allow inserting middleware at arbitrary points in the middleware stack - [@rosa](https://github.com/rosa). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind cleaning this up. Looks like some case-sensitive changes creeped in here that shouldn't be part of this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG, sorry. fixed.
d606f17
to
dab3a9a
Compare
rails-3.2 and ruby-2.1 has passed specs on travis. https://travis-ci.org/ruby-grape/grape/jobs/158980775 |
Merged, thanks! |
ref #1469