Yet more failing tests for optional parameter behavior around Arrays #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a lot of this is fixed now, @al2o3cr care to rebase and retest and potentially PR there specs with passing? |
|
Is there any possible to change some spec in this PR and not creating another PR? |
|
I don't think you can tack your changes on top of someone else's PR, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another group of failing tests for parameter parsing. See also related issues / PRs:
615 encounters similar behavior with defaults inside an optional Array
895 tests some of the same behavior, but with optional params inside an optional Array
723 encounters identical behavior (nested optional Array containing required params forces all elements of the array to have an optional value)
Creating this PR for discussion of the cases + any resolution I come up with.