Fix a build error when using Psych 4.0 #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the following build error when using Psych 4.0.
```console
% ruby -v
ruby 3.1.0dev (2021-05-17T10:51:51Z master ee611341c9) [x86_64-darwin19]
% cd path/to/i18n
% bundle exec rake
(snip)
Finished in 1.310478s, 1265.1872 runs/s, 2004.6121 assertions/s.
1) Error:
KeyValueCacheFileTest#test_load_translations_caches_file_through_updated_modification_time:
I18n::InvalidLocaleData: can not load translations from
/var/folders/6j/5l8q3y250b97529_tcssrwlm0000gn/T/test20210528-81604-ijnu7v.yml:
#<Psych::DisallowedClass: Tried to load unspecified class: Symbol>
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:245:in
`rescue in load_yml'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:241:in
`load_yml'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:226:in
`load_file'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/cache_file.rb:23:in
`load_file'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:18:in
`block in load_translations'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:18:in
`each'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:18:in
`load_translations'
/Users/koic/src/github.com/ruby-i18n/i18n/test/backend/cache_file_test.rb:49:in
`block (2 levels) in <module:CacheFileTest>'
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/3.1.0/tempfile.rb:317:in
`open'
/Users/koic/src/github.com/ruby-i18n/i18n/test/backend/cache_file_test.rb:43:in
`block in <module:CacheFileTest>'
2) Error:
SimpleCacheFileTest#test_load_translations_caches_file_through_updated_modification_time:
I18n::InvalidLocaleData: can not load translations from
/var/folders/6j/5l8q3y250b97529_tcssrwlm0000gn/T/test20210528-81604-9kcvkm.yml:
#<Psych::DisallowedClass: Tried to load unspecified class: Symbol>
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:245:in
`rescue in load_yml'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:241:in
`load_yml'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:226:in
`load_file'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/cache_file.rb:23:in
`load_file'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:18:in
`block in load_translations'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:18:in
`each'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:18:in
`load_translations'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/simple.rb:79:in
`init_translations'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/simple.rb:89:in
`lookup'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n/backend/base.rb:32:in
`translate'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n.rb:207:in `block
in translate'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n.rb:203:in `catch'
/Users/koic/src/github.com/ruby-i18n/i18n/lib/i18n.rb:203:in
`translate'
/Users/koic/src/github.com/ruby-i18n/i18n/test/backend/cache_file_test.rb:50:in
`block (2 levels) in <module:CacheFileTest>'
/Users/koic/.rbenv/versions/3.1.0-dev/lib/ruby/3.1.0/tempfile.rb:317:in
`open'
/Users/koic/src/github.com/ruby-i18n/i18n/test/backend/cache_file_test.rb:43:in
`block in <module:CacheFileTest>'
1658 runs, 2627 assertions, 0 failures, 2 errors, 0 skips
rake aborted!
```
This breaking is because an incompatibility with Psych 4.0.
- ruby/psych#487
- https://bugs.ruby-lang.org/issues/17866
For example, this PR solves the problem of faker gem that depend on i18n gem.
faker-ruby/faker#2330
|
Hi, C:\Ruby27-x64\lib\ruby\gems\2.7.0\gems\i18n-1.8.10\lib\i18n ran "bundle exec rake" Do you know what's wrong here? Thanks |
|
👍 This works to solve the |
|
@radar wondering if there is any chance this could be merged? Ruby 3.1 with yjit goodness is just around the corner and it ships with latest Psych which makes for a bit of an adventure getting old projects working (also just for visibility @tenderlove ) |
|
LGTM, thank you @koic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following build error when using Psych 4.0.
This breaking is because an incompatibility with Psych 4.0.
For example, this PR solves the problem of faker gem that depend on i18n gem.
faker-ruby/faker#2330